Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in diagram demonstrating stack vs. heap values #25761

Merged
merged 1 commit into from
May 25, 2015

Conversation

ralexstokes
Copy link
Contributor

Typo in explanation of difference between stack and heap values.

baz is called at the end of a call to bar inside another call to foo. baz takes a copy of the value e which should have a value of 9 if following the rest of the stack trace.

This PR fixes this typo and should close #25635.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 24, 2015

📌 Commit c7f9201 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thank you so much!

@steveklabnik
Copy link
Member

Oh, future note: if you put "Fixes #12345" in your commit message, github will automatically close the issue when it's merged.

@ralexstokes
Copy link
Contributor Author

cool, thanks for the tip!

bors added a commit that referenced this pull request May 25, 2015
Typo in explanation of difference between stack and heap values.  

`baz` is called at the end of a call to `bar` inside another call to `foo`.  `baz` takes a copy of the value `e` which should have a value of 9 if following the rest of the stack trace.

This PR fixes this typo and should close #25635.
@bors
Copy link
Contributor

bors commented May 25, 2015

⌛ Testing commit c7f9201 with merge e9005fb...

@bors bors merged commit c7f9201 into rust-lang:master May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not giving the right value to a variable in the book
7 participants