Skip to content

Remove broken links from Rust book example #25947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove broken links from Rust book example #25947

wants to merge 1 commit into from

Conversation

alilleybrinker
Copy link
Contributor

This fixes some broken links that are not being properly turned into HTML links, and are instead being inserted into the final page verbatim. I'm not sure what changes can/should be made to alleviate this problem in the long term, and figure that simply removing the broken links for now is the quickest solution.

Here is what it currently looks like: https://www.dropbox.com/s/cjn120ur6m1dfgk/Screenshot%202015-06-01%2012.55.30.png?dl=0

This fixes some broken links that are not being properly turned into HTML links, and are instead being inserted into the final page verbatim. I'm not sure what changes can/should be made to alleviate this problem in the long term, and figure that simply removing the broken links for now is the quickest solution.

Here is what it currently looks like: https://www.dropbox.com/s/cjn120ur6m1dfgk/Screenshot%202015-06-01%2012.55.30.png?dl=0
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson
Copy link
Contributor

brson commented Jun 1, 2015

@bors r+ rollup Thanks!

@bors
Copy link
Collaborator

bors commented Jun 1, 2015

📌 Commit 2ab5f81 has been approved by brson

@steveklabnik
Copy link
Member

@bors: r-

@steveklabnik
Copy link
Member

This is actually fixed on nightly: http://doc.rust-lang.org/nightly/book/dining-philosophers.html

The issue was that the anchors were left off, and they were added in another commit.

Thank you for reporting and attempting to fix, though!

@alilleybrinker
Copy link
Contributor Author

Ah, no problem! I just had a friend going through the Rust book who noticed it. Glad to hear that it's already been resolved!

@steveklabnik
Copy link
Member

Specifically a499517 fixed it

@alilleybrinker alilleybrinker deleted the patch-1 branch June 1, 2015 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants