Skip to content

Clarify difference #26107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Clarify difference #26107

wants to merge 1 commit into from

Conversation

ChrisJefferson
Copy link
Contributor

When reading this, I wondered how it had been "lightly adjusted". After careful diffing I discovered the change was the removal of gender-specific terms. I am happy with this change, but I feel you should be concrete about changes which have been made to long direct quotes, so readers know how they differ from the source material.

When reading this, I wondered how it had been "lightly adjusted". After careful diffing I discovered the change was the removal of gender-specific terms. I am happy with this change, but I feel you should be concrete about changes which have been made to long direct quotes, so readers know how they differ from the source material.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@dotdash
Copy link
Contributor

dotdash commented Jun 17, 2015

r? @steveklabnik

@steveklabnik
Copy link
Member

This particular part has been subject to a lot of churn, and I'd prefer to not keep bikeshedding it further. I can appreciate wanting some clarity here, but I also don't feel that it's worth making it stick out like a sore thumb either. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants