Skip to content

Conversation

rutsky
Copy link
Contributor

@rutsky rutsky commented Jun 30, 2015

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Manishearth
Copy link
Member

@bors r+ rollup

Sorry about the delay, and thanks!

@bors
Copy link
Collaborator

bors commented Jul 15, 2015

📌 Commit b85aa78 has been approved by Manishearth

@rutsky
Copy link
Contributor Author

rutsky commented Jul 15, 2015

@Manishearth I have few more minor documentation fixes, should I include r? @steveklabnik in the commit message or it's not useful any more?

@steveklabnik
Copy link
Contributor

You don't need to put it in the commit message, you can just put it in the PR.

I was sick the last three days, so that's why there was the delay. So sorry! 😰 😷 😵

In the future I'll be faster.

@rutsky
Copy link
Contributor Author

rutsky commented Jul 15, 2015

You don't need to put it in the commit message, you can just put it in the PR.

I made slip of the keyboard, of course in the PR, not in the commit message.

I was sick the last three days, so that's why there was the delay. So sorry!

Get well soon!

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2015
@bors bors merged commit b85aa78 into rust-lang:master Jul 17, 2015
@rutsky rutsky deleted the patch-1 branch July 17, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants