Cleanup configure nits #27331

Closed
wants to merge 8 commits into
from

Projects

None yet

7 participants

@sstewartgallus
Contributor

So, I'm doing more things to cleanup the configure script.

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@tamird

is this safe? don't you need it to happen in a subshell?

I agree this was right before: the parenthesize here is to prevent the directory change in the main script. Also, why does this lose the local declaration?

Look closer. Those aren't '{" and "}" they are "(" and ")" which means that the function executes in a subshell instead of as a compound command. I decided to put the use of _path inside of the subshell while I was working there because POSIX shell scripting has no such thing as the local declaration and I decided to fix that while I was there.

Ok, I see. I prefer to leave this patch out: putting the parens on the function declaration is non-obvious (I didn't see it), and local declarations are the one deviation from POSIX shell I purposefully allow in shell scripts (based on the precedent of shellfire which has fairly high compatibility), since globals everywhere is nearly unmanageable.

Owner

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned pcwalton Jul 27, 2015
Contributor
bors commented Jul 28, 2015

☔️ The latest upstream changes (presumably #27250) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor
bors commented Jul 28, 2015

☔️ The latest upstream changes (presumably #27173) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

I did make this ready merge and change the parts talked about.

Contributor
brson commented Aug 12, 2015

I haven't seen this PR before. Will review tomorrow.

Contributor
bors commented Aug 12, 2015

☔️ The latest upstream changes (presumably #27630) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor
brson commented Aug 14, 2015

r=me I'm sorry I forgot about this.

Contributor
tamird commented Sep 24, 2015

needs a rebase

Owner

Closing due to inactivity, but feel free to resend with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment