Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup configure nits #27331

Closed

Conversation

@sstewartgallus
Copy link
Contributor

@sstewartgallus sstewartgallus commented Jul 27, 2015

So, I'm doing more things to cleanup the configure script.

@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Jul 27, 2015

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@tamird

This comment has been minimized.

Copy link

@tamird tamird commented on configure in c1b8365 Jul 27, 2015

is this safe? don't you need it to happen in a subshell?

This comment has been minimized.

Copy link

@brson brson replied Jul 27, 2015

I agree this was right before: the parenthesize here is to prevent the directory change in the main script. Also, why does this lose the local declaration?

This comment has been minimized.

Copy link
Owner Author

@sstewartgallus sstewartgallus replied Jul 28, 2015

Look closer. Those aren't '{" and "}" they are "(" and ")" which means that the function executes in a subshell instead of as a compound command. I decided to put the use of _path inside of the subshell while I was working there because POSIX shell scripting has no such thing as the local declaration and I decided to fix that while I was there.

This comment has been minimized.

Copy link

@brson brson replied Jul 28, 2015

Ok, I see. I prefer to leave this patch out: putting the parens on the function declaration is non-obvious (I didn't see it), and local declarations are the one deviation from POSIX shell I purposefully allow in shell scripts (based on the precedent of shellfire which has fairly high compatibility), since globals everywhere is nearly unmanageable.

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Jul 27, 2015

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned pcwalton Jul 27, 2015
@bors
Copy link
Contributor

@bors bors commented Jul 28, 2015

The latest upstream changes (presumably #27250) made this pull request unmergeable. Please resolve the merge conflicts.

…up-configure-nits

Conflicts:
	configure
@bors
Copy link
Contributor

@bors bors commented Jul 28, 2015

The latest upstream changes (presumably #27173) made this pull request unmergeable. Please resolve the merge conflicts.

…up-configure-nits

Conflicts:
	configure
@sstewartgallus
Copy link
Contributor Author

@sstewartgallus sstewartgallus commented Aug 2, 2015

I did make this ready merge and change the parts talked about.

@brson
Copy link
Contributor

@brson brson commented Aug 12, 2015

I haven't seen this PR before. Will review tomorrow.

@bors
Copy link
Contributor

@bors bors commented Aug 12, 2015

The latest upstream changes (presumably #27630) made this pull request unmergeable. Please resolve the merge conflicts.

@brson
Copy link
Contributor

@brson brson commented Aug 14, 2015

r=me I'm sorry I forgot about this.

@tamird
Copy link
Contributor

@tamird tamird commented Sep 24, 2015

needs a rebase

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Oct 7, 2015

Closing due to inactivity, but feel free to resend with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants