Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some examples for the print! macro #28047

Merged
merged 1 commit into from Aug 28, 2015
Merged

Add some examples for the print! macro #28047

merged 1 commit into from Aug 28, 2015

Conversation

steveklabnik
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Do these doc examples pass? I'd expect the unused_must_use lint to trigger on not handling the return value from flush(). If it's passing now (or if it starts passing later) r=me though, thanks!

@steveklabnik
Copy link
Member Author

Hmm, I thought I ran the tests, but maybe I missed macros.

@steveklabnik steveklabnik force-pushed the doc_print branch 2 times, most recently from ea35d39 to d9819b7 Compare August 27, 2015 23:02
@steveklabnik
Copy link
Member Author

@bors: r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Aug 28, 2015

📌 Commit d9819b7 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 28, 2015

⌛ Testing commit d9819b7 with merge ab792ab...

bors added a commit that referenced this pull request Aug 28, 2015
@bors
Auto merge of #28047 - steveklabnik:doc_print, r=alexcrichton
ab792ab
@bors
Copy link
Contributor

bors commented Aug 28, 2015

💔 Test failed - auto-win-msvc-32-opt

@steveklabnik
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Aug 28, 2015

⚡ Previous build results for auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt...

@bors
Copy link
Contributor

bors commented Aug 28, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit d9819b7 into rust-lang:master Aug 28, 2015
@steveklabnik steveklabnik deleted the doc_print branch June 19, 2016 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steveklabnik @rust-highfive @alexcrichton @bors