Add note about clone in docs for vec![] #28272
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// using this with types having a nonstandard `Clone` implementation. For | ||
| /// example, `vec![Rc::new(1), 5]` will create a vector of five references | ||
| /// to the same boxed integer value, not five references pointing to independent | ||
| /// boxed integer. |
There was a problem hiding this comment.
This should be
pointing to independently boxed integers
|
r=me after nit |
Manishearth
force-pushed
the
improve_vec_docs
branch
from
cc2b9a8 to
3a87d1d
Compare
|
@bors r=steveklabnik rollup agh, was going to write "independent integers" and forgot to change it properly |
|
📌 Commit 3a87d1d has been approved by |
| /// | ||
| /// This will use `clone()` to duplicate an expression, so one should be careful | ||
| /// using this with types having a nonstandard `Clone` implementation. For | ||
| /// example, `vec![Rc::new(1), 5]` will create a vector of five references |
Manishearth
force-pushed
the
improve_vec_docs
branch
from
3a87d1d to
f669be8
Compare
|
@bors r=steveklabnik rollup |
|
📌 Commit f669be8 has been approved by |
| /// | ||
| /// This will use `clone()` to duplicate an expression, so one should be careful | ||
| /// using this with types having a nonstandard `Clone` implementation. For | ||
| /// example, `vec![Rc::new(1) 5]` will create a vector of five references |
|
@bors r- |
Manishearth
force-pushed
the
improve_vec_docs
branch
from
f669be8 to
5e2d854
Compare
|
@bors r=steveklabnik rollup agh, fixed |
|
📌 Commit 5e2d854 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @steveklabnik