Skip to content

Added useful links section #28366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2015
Merged

Added useful links section #28366

merged 2 commits into from
Sep 13, 2015

Conversation

alexispurslane
Copy link
Contributor

This is something that I wish I had when I started contributing to Rust (not that long ago :). I plan on writing a manual for bors and the rust testing setup too, if there isn't one already.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

llvm change needs reverted :)

@alexispurslane
Copy link
Contributor Author

OK.

@alexispurslane
Copy link
Contributor Author

(I squashed the commits too)

@alexcrichton
Copy link
Member

r? @steveklabnik

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2015

📌 Commit d09ba5d has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thank you!

@bors
Copy link
Collaborator

bors commented Sep 12, 2015

⌛ Testing commit d09ba5d with merge f710aae...

bors added a commit that referenced this pull request Sep 12, 2015
This is something that I wish I had when I started contributing to Rust (not that long ago :). I plan on writing a manual for bors and the rust testing setup too, if there isn't one already.
@bors bors merged commit d09ba5d into rust-lang:master Sep 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants