Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Implement FromStr for SocketAddrV{4,6} #29190

Merged
merged 1 commit into from Oct 21, 2015

Conversation

@alexcrichton
Copy link
Member

alexcrichton commented Oct 20, 2015

This was already implemented for SocketAddr, so the other types are lacking it
is just an oversight!

Closes #29183

This was already implemented for SocketAddr, so the other types are lacking it
is just an oversight!

Closes #29183
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 20, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Oct 20, 2015

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 20, 2015

📌 Commit 8aa6a11 has been approved by brson

@brson brson added the relnotes label Oct 20, 2015
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 21, 2015

⌛️ Testing commit 8aa6a11 with merge ff5cc89...

bors added a commit that referenced this pull request Oct 21, 2015
This was already implemented for SocketAddr, so the other types are lacking it
is just an oversight!

Closes #29183
@bors bors merged commit 8aa6a11 into rust-lang:master Oct 21, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
homu Test successful
Details
@alexcrichton alexcrichton deleted the alexcrichton:from-str-socket-addr branch Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.