Improve E0211 error diagnostic #29260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/librustc_typeck/diagnostics.rs
Outdated
There was a problem hiding this comment.
"You used a function or type which doesn't fit the requirements for where it was used"
(definition is wrong here)
There was a problem hiding this comment.
I thought it was an invalid type/function which didn't correspond to what was expected. Whar is still wrong ?
There was a problem hiding this comment.
Not all of these have a corresponding "definition"
There was a problem hiding this comment.
Which one doesn't have then ? And what "global" explanation would you give instead ?
GuillaumeGomez
force-pushed
the
E0211_improvement
branch
from
20789c4 to
10b0a51
Compare
src/librustc_typeck/diagnostics.rs
Outdated
GuillaumeGomez
force-pushed
the
E0211_improvement
branch
from
10b0a51 to
77053e2
Compare
|
Updated ! |
|
@bors r+ rollup |
|
📌 Commit 77053e2 has been approved by |
There was a problem hiding this comment.
odd spacing here with the colon
There was a problem hiding this comment.
Oups, french habit...
bors
added a commit
that referenced
this pull request
Oct 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
cc #29248