Skip to content

mk: Re-add libgcc_s_seh-1.dll to windows dist #29403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2015
Merged

mk: Re-add libgcc_s_seh-1.dll to windows dist #29403

merged 1 commit into from
Oct 28, 2015

Conversation

alexcrichton
Copy link
Member

Although the compiler itself does not depend on this DLL the libstdc++-6.dll
that we're shipping does, so we still need to include it.

@alexcrichton
mk: Re-add libgcc_s_seh-1.dll to windows dist
98dcde1 
Although the compiler itself does not depend on this DLL the `libstdc++-6.dll`
that we're shipping does, so we still need to include it.
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

cc #29306, where I erroneously removed this.

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 28, 2015
@retep998 retep998 mentioned this pull request Oct 28, 2015
Closed
@brson
Copy link
Contributor

brson commented Oct 28, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 28, 2015

📌 Commit 98dcde1 has been approved by brson

@retep998 retep998 mentioned this pull request Oct 28, 2015
Closed
bors added a commit that referenced this pull request Oct 28, 2015
@bors
Auto merge of #29403 - alexcrichton:fix-windows-again-zomg, r=brson
65623db 
Although the compiler itself does not depend on this DLL the `libstdc++-6.dll`
that we're shipping does, so we still need to include it.
@bors
Copy link
Collaborator

bors commented Oct 28, 2015

⌛ Testing commit 98dcde1 with merge 65623db...

@bors
Copy link
Collaborator

bors commented Oct 28, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 98dcde1 into rust-lang:master Oct 28, 2015
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 29, 2015
@alexcrichton alexcrichton mentioned this pull request Oct 29, 2015
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 29, 2015
@alexcrichton alexcrichton deleted the fix-windows-again-zomg branch October 31, 2015 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcrichton @rust-highfive @brson @bors