Skip to content

[MIR trans] Add support for SwitchInt #29697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2015
Merged

[MIR trans] Add support for SwitchInt #29697

merged 1 commit into from
Nov 10, 2015

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Nov 8, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented Nov 8, 2015

r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned arielb1 Nov 8, 2015
nagisa
nagisa reviewed Nov 8, 2015
View reviewed changes
src/librustc_trans/trans/mir/block.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlong line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, fixed, thanks!

@dotdash dotdash force-pushed the mir_trans_switchint branch 2 times, most recently from 883c3d1 to be93cd6 Compare November 9, 2015 10:22
nikomatsakis
nikomatsakis reviewed Nov 9, 2015
View reviewed changes
src/librustc_trans/trans/mir/block.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: funny comma here

s/bcx ,/bcx, /

@nikomatsakis
Copy link
Contributor

r=me when the nit is fixed, nice!

@dotdash dotdash force-pushed the mir_trans_switchint branch from be93cd6 to b0d7338 Compare November 9, 2015 15:55
@dotdash
Copy link
Contributor Author

dotdash commented Nov 9, 2015

@bors r=nikomatsakis b0d7338

bors added a commit that referenced this pull request Nov 9, 2015
@bors
Auto merge of #29697 - dotdash:mir_trans_switchint, r=nikomatsakis
20d4c6a
@bors
Copy link
Collaborator

bors commented Nov 9, 2015

⌛ Testing commit b0d7338 with merge 20d4c6a...

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Nov 9, 2015 at 10:59 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/7032

—
Reply to this email directly or view it on GitHub
#29697 (comment).

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

💣 Failed to start rebuilding: 502 Bad Gateway

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

⌛ Testing commit b0d7338 with merge 29732f1...

@alexcrichton
Copy link
Member

@bors: retry force

On Mon, Nov 9, 2015 at 11:02 AM, bors notifications@github.com wrote:

[image: ⌛] Testing commit b0d7338
b0d7338
with merge 29732f1
29732f1
...

—
Reply to this email directly or view it on GitHub
#29697 (comment).

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

⌛ Testing commit b0d7338 with merge 2bd48d6...

@bors
Copy link
Collaborator

bors commented Nov 9, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Nov 9, 2015 at 3:02 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/7038

—
Reply to this email directly or view it on GitHub
#29697 (comment).

@bors
Copy link
Collaborator

bors commented Nov 10, 2015

⌛ Testing commit b0d7338 with merge 63542d6...

@bors
Copy link
Collaborator

bors commented Nov 10, 2015

💔 Test failed - auto-mac-64-nopt-t

@dotdash
Copy link
Contributor Author

dotdash commented Nov 10, 2015

@bors retry

2015-11-10 12:34 GMT+01:00 bors notifications@github.com:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/7078

—
Reply to this email directly or view it on GitHub
#29697 (comment).

@bors
Copy link
Collaborator

bors commented Nov 10, 2015

⌛ Testing commit b0d7338 with merge e9aa32a...

bors added a commit that referenced this pull request Nov 10, 2015
@bors
Auto merge of #29697 - dotdash:mir_trans_switchint, r=nikomatsakis
e9aa32a
@bors
Copy link
Collaborator

bors commented Nov 10, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit b0d7338 into rust-lang:master Nov 10, 2015
@bors bors mentioned this pull request Nov 10, 2015
Merged
@dotdash dotdash deleted the mir_trans_switchint branch January 15, 2016 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dotdash @rust-highfive @arielb1 @nikomatsakis @bors @alexcrichton @nagisa