Skip to content

Conversation

michaelwoerister
Copy link
Member

Add a missing case in LvalueTy::projection_ty() that popped up earlier today.

cc @rust-lang/compiler @nikomatsakis

@rust-highfive
Copy link
Contributor

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister michaelwoerister added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html labels Nov 13, 2015
@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 13, 2015

📌 Commit 9211883 has been approved by nikomatsakis

@arielb1
Copy link
Contributor

arielb1 commented Nov 13, 2015

test please

@bors
Copy link
Collaborator

bors commented Nov 14, 2015

⌛ Testing commit 9211883 with merge 45087f3...

bors added a commit that referenced this pull request Nov 14, 2015
…matsakis

Add a missing case in LvalueTy::projection_ty() that popped up earlier today.

cc @rust-lang/compiler @nikomatsakis
@bors bors merged commit 9211883 into rust-lang:master Nov 14, 2015
@nikomatsakis
Copy link
Contributor

it's true, a test would have been good, although this patch looked pretty
obviously correct to me. we'll have a ton of tests from trans soon enough...

On Sat, Nov 14, 2015 at 3:03 AM, bors notifications@github.com wrote:

Merged #29817 #29817.


Reply to this email directly or view it on GitHub
#29817 (comment).

@arielb1
Copy link
Contributor

arielb1 commented Nov 14, 2015

@nikomatsakis

I prefer adding tests before I make a change, otherwise things have a tendency not to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants