Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright date #30665

Merged
merged 1 commit into from
Jan 6, 2016
Merged

Update copyright date #30665

merged 1 commit into from
Jan 6, 2016

Conversation

panzarino
Copy link
Contributor

New copyright date

Happy new year!

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Jan 1, 2016

AFAIK we change the years only when we actually modify those files (not sure if make tidy checks that).

@panzarino
Copy link
Contributor Author

Sorry, I didn't know.

LICENSE-MIT and COPYRIGHT files should still be changed

I can update this PR to only change those files if that's what you would like.

@hanna-kruppe
Copy link
Contributor

@eddyb We don't even consistently update the years when modifying files. As one random example, src/libsyntax/attr.rs has been modified throughout 2015 but is still "Copyright 2012-2014".

@frewsxcv
Copy link
Member

frewsxcv commented Jan 1, 2016

These shouldn't be updated for the sake of being updated

Previous discussion: #9070

@eddyb
Copy link
Member

eddyb commented Jan 1, 2016

@zachpanz88 If you want to work on this you could add support to src/etc/licenseck.py/src/etc/tidy.py to check the year based on the date of the git last commit.

I would be glad to have these updated according to their changes.

@panzarino
Copy link
Contributor Author

I have updated this PR to only change the LICENSE-MIT and COPYRIGHT files.

@eddyb I can work on updating the files you mentioned above. You would want it to automatically update the comment at the top of the file to match the date at which the file was last updated correct?

@eddyb
Copy link
Member

eddyb commented Jan 1, 2016

@zachpanz88 The scripts are supposed to check but not actually modify files. Auto-modification functionality would have to be separate.

@panzarino
Copy link
Contributor Author

@eddyb Okay, so you want the program to check if the copyright date is the same as the last modified date and if not, display a message to the user.

@retep998
Copy link
Member

retep998 commented Jan 1, 2016

Specifically those programs should cause make tidy to fail if they don't match, that way people would be forced to not forget.

@frewsxcv
Copy link
Member

frewsxcv commented Jan 2, 2016

This pull request looks good to me with the latest changes

@nrc
Copy link
Member

nrc commented Jan 4, 2016

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2016

📌 Commit d5c8f62 has been approved by nrc

@bors
Copy link
Contributor

bors commented Jan 5, 2016

⌛ Testing commit d5c8f62 with merge ebc6ca8...

@bors
Copy link
Contributor

bors commented Jan 5, 2016

💔 Test failed - auto-linux-64-nopt-t

@panzarino
Copy link
Contributor Author

Not sure how that could have happened

@eddyb
Copy link
Member

eddyb commented Jan 5, 2016

@zachpanz88 It's spurious, we've seen a lot of these lately.

@bors retry

bors added a commit that referenced this pull request Jan 5, 2016
New copyright date

Happy new year!
@bors
Copy link
Contributor

bors commented Jan 5, 2016

⌛ Testing commit d5c8f62 with merge bd58fd8...

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
@bors bors merged commit d5c8f62 into rust-lang:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants