Fix type parameter default error to mention type and trait definitions #30997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -1923,7 +1923,7 @@ fn get_or_create_type_parameter_def<'a,'tcx>(ccx: &CrateCtxt<'a,'tcx>, | |||
| param.id, | |||
| param.span, | |||
| format!("defaults for type parameters are only allowed on type definitions, \ | |||
| like `struct` or `enum`")); | |||
There was a problem hiding this comment.
Seems like if we're going to try and be exhaustive, we ought to include type aliases too. I also think we should add trait into the list with struct and enum, like so: "defaults for type parameters are only allowed in struct, enum, type, or trait definitions".
Introduced in PR rust-lang#30724, needs to mention that type parameter defaults are legal in trait and type definitions too.
bluss
changed the title
|
Good idea, I've updated it to say exactly that. |
|
📌 Commit 9d77694 has been approved by |
|
@bors rollup |
|
⌛ Testing commit 9d77694 with merge b78b9ae... |
bors
added a commit
that referenced
this pull request
Jan 23, 2016
Fix type parameter default error to mention type and trait definitions Introduced in PR #30724, needs to mention that type parameter defaults are legal in trait and type definitions too.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 23, 2016
Fix type parameter default error to mention type and trait definitions Introduced in PR rust-lang#30724, needs to mention that type parameter defaults are legal in trait and type definitions too.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 23, 2016
Fix type parameter default error to mention type and trait definitions Introduced in PR rust-lang#30724, needs to mention that type parameter defaults are legal in trait and type definitions too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix type parameter default error to mention type and trait definitions
Introduced in PR #30724, needs to mention that type parameter defaults
are legal in trait and type definitions too.