Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move more checks from librustc to librustc_passes #31024

Merged
merged 1 commit into from
Jan 21, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 19, 2016

  • check_const
  • check_static_recursion
  • check_loop
  • check_rvalues

r? @arielb1

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arielb1
Copy link
Contributor

arielb1 commented Jan 19, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2016

📌 Commit 6c2990d has been approved by arielb1

bors added a commit that referenced this pull request Jan 19, 2016
-    check_const
-    check_static_recursion
-    check_loop
-    check_rvalues

r? @arielb1
@bors
Copy link
Contributor

bors commented Jan 19, 2016

⌛ Testing commit 6c2990d with merge ce6ace7...

@bors
Copy link
Contributor

bors commented Jan 19, 2016

💔 Test failed - auto-win-gnu-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Jan 19, 2016 at 12:36 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-nopt-t/builds/2771


Reply to this email directly or view it on GitHub
#31024 (comment).

@bors
Copy link
Contributor

bors commented Jan 21, 2016

🔒 Merge conflict

@bors
Copy link
Contributor

bors commented Jan 21, 2016

☔ The latest upstream changes (presumably #31010) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 21, 2016

rebased

@arielb1
Copy link
Contributor

arielb1 commented Jan 21, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2016

📌 Commit c124dec has been approved by arielb1

bors added a commit that referenced this pull request Jan 21, 2016
-    check_const
-    check_static_recursion
-    check_loop
-    check_rvalues

r? @arielb1
@bors
Copy link
Contributor

bors commented Jan 21, 2016

⌛ Testing commit c124dec with merge 340e7eb...

@bors bors merged commit c124dec into rust-lang:master Jan 21, 2016
@oli-obk oli-obk deleted the move_checks_out_of_librustc branch January 26, 2016 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants