Refactor windows::fs::FileAttr #31675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we no longer use `GetFileAttributesExW` FileAttr is never created directly from `WIN32_FILE_ATTRIBUTE_DATA` anymore. So we should no longer store FileAttr's attributes in that c struct.
|
An other question. This pr and my previous ones make some functions and constants in windows::c unnecessary. Should I remove them? Why does this module not warn on dead code anyway? |
|
Ah yeah I was hoping we could just change the contained struct to something else but this is also fine (as it doesn't look like there's a shared struct to use like there is on Unix). We can always add more fields over time! You can also feel free to clean out |
bors
added a commit
that referenced
this pull request
Feb 16, 2016
Because we no longer use `GetFileAttributesExW` FileAttr is never created directly from `WIN32_FILE_ATTRIBUTE_DATA` anymore. So we should no longer store FileAttr's attributes in that c struct. r? @alexcrichton Is this what you had in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we no longer use
GetFileAttributesExWFileAttr is never created directly fromWIN32_FILE_ATTRIBUTE_DATAanymore. So we should no longer store FileAttr's attributes in that c struct.r? @alexcrichton
Is this what you had in mind?