Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to how to disable the default prelude #31900

Closed
wants to merge 1 commit into from

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Feb 26, 2016

Running grep -r no_implicit_prelude doc src/{libstd,libcore} resulted in only
the one hit in the reference. Added links from the documentation for
std::prelude and core::prelude::v1 to make it easier to find.

r? @steveklabnik

Running `grep -r no_implicit_prelude doc src/{libstd,libcore}` resulted in only
the one hit in the reference. Added links from the documentation for
`std::prelude` and `core::prelude::v1` to make it easier to find.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Nemo157
Copy link
Member Author

Nemo157 commented Feb 26, 2016

I think make docs has decided to do a full rebuild so it's probably gonna be a couple of hours till I can check that the relative references are actually correct... pretty sure they are though.

@Nemo157
Copy link
Member Author

Nemo157 commented Feb 26, 2016

Finally finished building (under 2 hours 😄) and the links work fine.

@alexcrichton
Copy link
Member

I... don't think that this was intended to be stable actually, it's probably a mistake that it's accepted on the stable compiler. We have an accepted RFC to rename this attribute but unfortunately the tracking issue has seen very little activity.

@petrochenkov
Copy link
Contributor

Prelude mechanics will likely require some rethinking after the name resolution reform.

@Nemo157
Copy link
Member Author

Nemo157 commented Feb 26, 2016

Heh, I did search the issues for no_implicit_prelude to see if there were any issues around it and couldn't find any. Looks like #20561 doesn't mention it by name at all.

@Nemo157
Copy link
Member Author

Nemo157 commented Feb 26, 2016

@alexcrichton would no_prelude be stable if #20561 were implemented, or are there reasons to not want this stabilised yet?

@alexcrichton
Copy link
Member

I think that no_prelude would likely have a period of instability after which it'd go through FCP for stabilization. (as most unstable features do)

@Nemo157
Copy link
Member Author

Nemo157 commented Feb 26, 2016

Ok, I was thinking I could maybe look at implementing #20561 in the next few days to try and get it moving towards stabilisation. I guess no_implicit_prelude will need to be deprecated and no_prelude would be feature gated at first? If that were done would adding the documentation pointing to it prior to stabilisation be fine, or should it be left undocumented (or just documented in the nightly docs maybe?) until it's stable?

@alexcrichton
Copy link
Member

Oh that'd be great to get that implemented! We'd probably want to hold off documentation in the prelude itself until its stable, but there are nightly sections of the docs it would fit well into.

@Nemo157
Copy link
Member Author

Nemo157 commented Feb 27, 2016

Cool, I should hopefully get to it in the next week assuming it's not to hard. Thanks for the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants