Fix LLVM assert with write_volatile #32233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let val = if type_is_immediate(bcx.ccx(), tp_ty) { | ||
| from_arg_ty(bcx, llargs[1], tp_ty) | ||
| } else { | ||
| Load(bcx, from_arg_ty(bcx, llargs[1], tp_ty)) |
There was a problem hiding this comment.
You don't need to transform llargs[1], if it's not immediate then it's a pointer to the value you want (Load wouldn't work otherwise anyway).
There was a problem hiding this comment.
llargs[1] is the value that needs to be stored. llargs[0] is the pointer to the store destination.
There was a problem hiding this comment.
If not immediate, then it's passed indirectly and llargs[1] is a pointer to the value that needs to be stored.
There was a problem hiding this comment.
Oh nevermind, I see what the problem is.
|
@bors r+ |
|
📌 Commit 86fd5a0 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 14, 2016
Fix LLVM assert with write_volatile Fixes #29663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29663