Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Fix inheriting stdin on status() #32257

Merged
merged 1 commit into from
Mar 26, 2016
Merged

std: Fix inheriting stdin on status() #32257

merged 1 commit into from
Mar 26, 2016

Conversation

alexcrichton
Copy link
Member

This regression was accidentally introduced in #31618, and it's just flipping a
boolean!

Closes #32254

@alexcrichton
std: Fix inheriting stdin on status()
4124466 
This regression was accidentally introduced in rust-lang#31618, and it's just flipping a
boolean!

Closes rust-lang#32254
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@rprichard
Copy link
Contributor

The documentation also says that output() captures stdin here and here. My impression is that output() used to create a pipe for stdin, but because output() doesn't return a std::process::ChildStdin, there was no way to write to the pipe. Therefore, I think the current behavior is right; the docs just need updating.

@alexcrichton
Copy link
Member Author

@rprichard this PR is for the status() function though?

@rprichard
Copy link
Contributor

@alexcrichton Yeah, output()'s documentation fix could be a different PR. This change looks good to me as-is.

@aturon
Copy link
Member

aturon commented Mar 25, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 25, 2016

📌 Commit 4124466 has been approved by aturon

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
@Manishearth
Rollup merge of rust-lang#32257 - alexcrichton:fix-status-stdin, r=at…
0274432 
…uron

std: Fix inheriting stdin on status()

This regression was accidentally introduced in rust-lang#31618, and it's just flipping a
boolean!

Closes rust-lang#32254
@Manishearth Manishearth mentioned this pull request Mar 26, 2016
Closed
bors added a commit that referenced this pull request Mar 26, 2016
@bors
Auto merge of #32495 - Manishearth:rollup, r=<try>
49312a4 
Rollup of 18 pull requests

- Successful merges: #32131, #32199, #32257, #32325, #32383, #32387, #32432, #32435, #32440, #32447, #32448, #32456, #32468, #32470, #32476, #32478, #32484, #32492
- Failed merges: #32240, #32469, #32482
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
@Manishearth
Rollup merge of rust-lang#32257 - alexcrichton:fix-status-stdin, r=at…
a8d59e0 
…uron

std: Fix inheriting stdin on status()

This regression was accidentally introduced in rust-lang#31618, and it's just flipping a
boolean!

Closes rust-lang#32254
@Manishearth Manishearth mentioned this pull request Mar 26, 2016
Merged
@Manishearth Manishearth reopened this Mar 26, 2016
This was referenced Mar 26, 2016
Closed
Closed
bors added a commit that referenced this pull request Mar 26, 2016
@bors
Auto merge of #32496 - Manishearth:rollup, r=Manishearth
d322f99 
Rollup of 11 pull requests

- Successful merges: #32131, #32199, #32257, #32325, #32435, #32447, #32448, #32456, #32469, #32476, #32482
- Failed merges: #32240
@bors bors merged commit 4124466 into rust-lang:master Mar 26, 2016
@alexcrichton alexcrichton mentioned this pull request Mar 26, 2016
Closed
@alexcrichton alexcrichton deleted the fix-status-stdin branch March 27, 2016 17:49
alexcrichton added a commit to alexcrichton/cargo that referenced this pull request Mar 30, 2016
@alexcrichton
Update Rust to pick up rust-lang/rust#32257
99c517b 
Closes rust-lang#2530
bors added a commit to rust-lang/cargo that referenced this pull request Mar 30, 2016
@bors
Auto merge of #2531 - alexcrichton:fix-stdin, r=alexcrichton
d38f03b 
Update Rust to pick up rust-lang/rust#32257

Closes #2530
@alexcrichton alexcrichton mentioned this pull request Mar 30, 2016
Closed
@saghm saghm mentioned this pull request Mar 30, 2016
Closed
apanda added a commit to NetSys/NetBricks that referenced this pull request Apr 14, 2016
@apanda
Squashed 'cargo/' changes from b4665f7..fb9916f
b8eb498 
fb9916f Merge branch 'master' of https://github.com/rust-lang/cargo
59238e8 Auto merge of #2575 - alexcrichton:bump, r=alexcrichton
1f889f7 Bump to 0.11.0
81debdd Auto merge of #2574 - alexcrichton:crates-io-bump, r=alexcrichton
5d87c4f Bump the crates-io crate to 0.2
88e3081 Auto merge of #2562 - smaximov:doc-add-env-vars, r=alexcrichton
2ef6fcb Add reference to env vars introduced in PR #2523 to the docs
4e1ffb1 Auto merge of #2561 - alexcrichton:update-tar, r=alexcrichton
11a0a31 Update dependency on tar
10ddd7d Auto merge of #2554 - alexcrichton:robust-test, r=alexcrichton
bc8e332 Make a test a bit more robust to the environment
34a7a06 Auto merge of #2465 - TheNeikos:add-version_env, r=alexcrichton
dd26ce3 Add a new CARGO_PKG_AUTHORS environment variable
31214eb Auto merge of #2385 - alexcrichton:top-level-overrides, r=wycats
f20ca62 Auto merge of #2547 - alexcrichton:more-locking, r=brson
6f6d7c8 Protect against concurrent access to Cargo.lock
a9fd1c2 Change `Config::target_dir` to return Filesystem
12f76a5 Auto merge of #2541 - alexcrichton:aarch64, r=alexcrichton
0f317c5 Download the aarch64 standard library on the bots
db60a09 Auto merge of #2534 - alexcrichton:lock-with-git-repos, r=brson
72690ba Auto merge of #2538 - alexcrichton:aarch64, r=alexcrichton
0a146ef Prepare for aarch64 nightlies and CI
fa7805a Auto merge of #2505 - srinivasreddy:improve_msg, r=alexcrichton
c63bbc6 remote unnecessary expression
fae9c53 Auto merge of #2491 - JIghtuse:master, r=alexcrichton
01cc9e1 Generate the lock file when there is no lock file
18e5930 Replace existing sources before updating
1a6a32e Auto merge of #2532 - japaric:musl, r=alexcrichton
d38f03b Auto merge of #2531 - alexcrichton:fix-stdin, r=alexcrichton
99c517b Update Rust to pick up rust-lang/rust#32257
d382d6a install-deps.py: add x86_64-unknown-linux-musl target
abdc756 Auto merge of #2523 - srinivasreddy:issue-2504, r=alexcrichton
3a654e4 implemented cargo package name as CARGO_PKG_NAME; And package description and home page are exposed as  CARGO_PKG_DESCRIPTION and CARGO_PKG_HOMEPAGE respectively. And add a test case - for CARGO_PKG_NAME, CARGO_PKR_DESCRIPTION, CARGO_HOMEPAGE.
54d738b Implement top-level overrides
12dbfa3 Reject manifest with duplicate dependencies in different targets

git-subtree-dir: cargo
git-subtree-split: fb9916f50201af8011180f9273c4a107952459a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexcrichton @rust-highfive @rprichard @aturon @bors @brson @Manishearth