Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add double underscores in derive #32294

Merged
merged 2 commits into from Mar 17, 2016
Merged

Re-add double underscores in derive #32294

merged 2 commits into from Mar 17, 2016

Conversation

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Mar 16, 2016

@durka, sanity-check, please?

Don't merge this yet, I need to add a test and test it locally.

ready for review

(fixes #32292)

@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Mar 16, 2016

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@durka
Copy link
Contributor

@durka durka commented Mar 16, 2016

Woo, highfive is back!

@@ -929,10 +929,10 @@ impl<'a> MethodDef<'a> {
///
/// // equivalent to:
/// impl PartialEq for A {
/// fn eq(&self, arg_1: &A) -> bool {
/// fn eq(&self, __arg_1: &A) -> bool {
/// match *self {
/// A {x: ref self_0_0, y: ref self_0_1} => {

This comment has been minimized.

@durka

durka Mar 16, 2016
Contributor

missed these comments, if you care

@Manishearth Manishearth force-pushed the Manishearth:derive-fix branch from ee16a8e to d488b2f Mar 16, 2016

#![deny(warnings)]

#[derive(Hash)]

This comment has been minimized.

@alexcrichton

alexcrichton Mar 16, 2016
Member

Can you add all other deriving modes here as well?

This comment has been minimized.

@Manishearth

Manishearth Mar 16, 2016
Author Member

done.

@Manishearth Manishearth force-pushed the Manishearth:derive-fix branch from 414b421 to e63a6af Mar 16, 2016
@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Mar 16, 2016

@durka
Copy link
Contributor

@durka durka commented Mar 17, 2016

I think this line needs to regain some underscores.

@Manishearth Manishearth force-pushed the Manishearth:derive-fix branch from e63a6af to 52e064c Mar 17, 2016
@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented Mar 17, 2016

@bors r=alexcrichton

Ah, fixed.

@bors
Copy link
Contributor

@bors bors commented Mar 17, 2016

📌 Commit 52e064c has been approved by alexcrichton

@bors
Copy link
Contributor

@bors bors commented Mar 17, 2016

Testing commit 52e064c with merge b12b4e4...

bors added a commit that referenced this pull request Mar 17, 2016
Re-add double underscores in derive (fixes #32292)

@durka, sanity-check, please?

<s>Don't merge this yet, I need to add a test and test it locally.</s>

ready for review
@bors bors merged commit 52e064c into rust-lang:master Mar 17, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:derive-fix branch Dec 2, 2016
@Manishearth Manishearth changed the title Re-add double underscores in derive (fixes #32292) Re-add double underscores in derive Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants