Skip to content

README: add logo & build status #32406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MatejLach
Copy link
Contributor

@alexcrichton
Copy link
Member

The logo looks like it's got a lot of whitespace around it, is there perhaps a way to mitigate that? I may also prefer to leave out the build status on Travis for now as we don't guarantee it's green, it doesn't reflect Windows, and the master branch is otherwise permanently green anyway because of bors.

@MatejLach
Copy link
Contributor Author

@alexcrichton Done, this is the best-looking logo I could find that's hosted on rust-lang.org

@brson
Copy link
Contributor

brson commented Mar 21, 2016

Thanks for the patch.

While I like the idea, the layout this results in doesn't feel balanced to me. There's a lot of whitespace, with the useful text pushed down the page quite a ways. It's hard for me to imagine a way to include the logo here in a way I'd find aesthetic without access to CSS.

So I'd rather not do this and am going to close without merging. Thank you again.

@brson brson closed this Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants