Rollup of 6 pull requests #33081
Merged
Rollup of 6 pull requests #33081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not reference machine 'pointers' in explanation of 'size' types.
Simplify explanation and rephrase as per @GuillaumeGomez's suggestion.
Replace "make for" by the slightly more accurate "account for".
Reading this, one item stood out a bit. Small improvements here. . ‘Compile-time’ is not a noun, ‘compilation time’ was meant; . Mathematical formulas are best not rendered as code; . Use the same tense as in other items.
Clarification by more precise specification.
The code examples and previous paragraphs all use `v` and `v2`
…labnik Avoid linking to itself in implementors section of trait page Fix rust-lang#32474.
…labnik Reword explanation of 'size' types. Do not reference machine 'pointers' in explanation of 'size' types. I think the number of elements that can be directly addressed is a fundamental feature of a machine architecture in its own right. The fact that it coincides with the ‘size’ of a pointer should be viewed as an ‘implementation detail’ ;)
Do not use "bind" to refer to both referencing and to assignment See https://users.rust-lang.org/t/difference-between-four-references/5406/7
grammar: fix Reading this, one item stood out a bit. Small improvements here. 1. ‘Compile-time’ is not a noun, ‘compilation time’ was meant; 1. Mathematical formulas are best not rendered as code; 1. Use the same tense as in other items.
…names-in-ownership, r=GuillaumeGomez Use `v` instead of `v1` for consistency The code examples and previous paragraphs all use `v` and `v2`
Update E0102's example (fixes rust-lang#33057) r? @GuillaumeGomez
|
r? @cmr (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit ec44ddc has been approved by |
bors
added a commit
that referenced
this pull request
Apr 18, 2016
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors: retry On Mon, Apr 18, 2016 at 1:44 PM, bors notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vinstead ofv1for consistency #33035, Update E0102's example (fixes #33057) #33058