fix issue #3222 #3316
Merged
fix issue #3222 #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! @nikomatsakis can you review this? |
|
I think the logic is basically right but the code should make use of some of the helper functions that are already there. Rather than creating a new function |
|
I use now load_if_immediate. It was typically the kind of function I was looking for and why I asked you to validate the commit. |
catamorphism
added a commit
that referenced
this pull request
Sep 5, 2012
|
Looks good, merged; thanks! |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Feb 25, 2024
Windows miri-script execution egronomics
This allows for Windows users to use miri-script without pain. As working on miri earlier I was doing
`.\miri-script\target\debug\miri-script.exe { install | build | ... }` which wasn't fun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowed strings have one indirection less than other strings. With the matched expression, an extra Load was done. With patterns, constant strings weren't Store/Load as needed.
I add a test: src/test/run-pass/alt-borrowed_str.rs
I start watching rust 2 weeks ago. Even if I did my best to make something consistent, the LLVM generator is quite hard to understand: I may have miss something. Please, before merging, check I didn't break the model.