Skip to content

rustc_driver: Allow running the compiler with a FileLoader#33217

Merged
bors merged 1 commit into
rust-lang:masterfrom
aochagavia:fileloader
Apr 28, 2016
Merged

rustc_driver: Allow running the compiler with a FileLoader#33217
bors merged 1 commit into
rust-lang:masterfrom
aochagavia:fileloader

Conversation

@aochagavia

Copy link
Copy Markdown
Contributor

cc @nrc. I chose to implement this in such a way that it doesn't break anything. Please let me know if you want me to change anything.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@aochagavia

Copy link
Copy Markdown
Contributor Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned Aatch Apr 26, 2016
Comment thread src/librustc_driver/lib.rs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: argument alignment

@nrc

nrc commented Apr 26, 2016

Copy link
Copy Markdown
Member

lgtm, r+ with the style nit addressed.

@aochagavia

Copy link
Copy Markdown
Contributor Author

@nrc Done 😄

@nrc

nrc commented Apr 27, 2016

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 27, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 6c50c88 has been approved by nrc

@bors

bors commented Apr 28, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6c50c88 with merge 115c6c8...

bors added a commit that referenced this pull request Apr 28, 2016
rustc_driver: Allow running the compiler with a FileLoader

cc @nrc. I chose to implement this in such a way that it doesn't break anything. Please let me know if you want me to change anything.
@bors bors merged commit 6c50c88 into rust-lang:master Apr 28, 2016
@aochagavia aochagavia deleted the fileloader branch April 30, 2016 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants