Add @aldeka's safe and unsafe Ferris to nomicon #33845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
force-pushed
the
safeandunsafe
branch
from
931b9a3 to
12d7758
Compare
|
Haha that's great! Can you update the rustbuild build rules for the nomicon as well? |
|
@alexcrichton I think this is the right way to do this. What do you think? |
steveklabnik
force-pushed
the
safeandunsafe
branch
from
12d7758 to
6bbee2d
Compare
|
Could you actually make a new |
|
(may also be worth running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back, @gankro asked @aldeka if a Ferris could be used in
the nomicon. But he did not ever get around to actually implementing it.
I have done so in this PR. 😄