Remove linking and intrinsics code made dead by only supporting LLVM 3.7 and up #34208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we only support LLVM 3.7 and above, we will never need to use the AR linker. Remove the possibility of calling it and all the now-dead code.
|
Surprising amount of cruft. |
|
⌛ Testing commit 448e254 with merge 682abf7... |
bors
added a commit
that referenced
this pull request
Jun 11, 2016
…crichton Remove linking and intrinsics code made dead by only supporting LLVM 3.7 and up This is mostly based on Alex's throwaway comment: > probably reject those that LLVM just doesn't support... So I'm more than happy to adjust the PR based on how you thought this should look. Also happy to split it into two PRs, one for linking and one for intrinsics. r? @alexcrichton /cc @nagisa @brson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly based on Alex's throwaway comment:
So I'm more than happy to adjust the PR based on how you thought this should look. Also happy to split it into two PRs, one for linking and one for intrinsics.
r? @alexcrichton
/cc @nagisa @brson