Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject invalid urls in linkchecker #34566

Merged
merged 1 commit into from
Jul 2, 2016

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jun 29, 2016

For example root-relative links will now be rejected.

Also remove some exceptions which have since been fixed and fix a typo in
the broken redirect handling.

For example root-relative links will now be rejected.

Also remove some exceptions which have since been fixed and fix a typo in
the broken redirect handling.
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 01386e6

@bors
Copy link
Contributor

bors commented Jul 1, 2016

⌛ Testing commit 01386e6 with merge 165c187...

@bors
Copy link
Contributor

bors commented Jul 1, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Jul 1, 2016 at 5:58 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1631


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34566 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95L5rJrvrfXmBrw4B18FaZB5c6C1Gks5qRQ7fgaJpZM4JBpjJ
.

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2016
…=alexcrichton

Reject invalid urls in linkchecker

For example root-relative links will now be rejected.

Also remove some exceptions which have since been fixed and fix a typo in
the broken redirect handling.
bors added a commit that referenced this pull request Jul 2, 2016
Rollup of 7 pull requests

- Successful merges: #34531, #34545, #34551, #34566, #34567, #34574, #34583
- Failed merges:
@bors
Copy link
Contributor

bors commented Jul 2, 2016

☔ The latest upstream changes (presumably #34611) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 01386e6 into rust-lang:master Jul 2, 2016
@ollie27 ollie27 deleted the linkchecker_invalid_urls branch July 5, 2016 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants