Fixed issue where importing a trait method directly and then calling the method causes a compiler panic #34797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doomrobo Also, two nits:
|
rozbb
force-pushed
the
fix-import-trait-method
branch
from
dcddb16 to
dfad625
Compare
There was a problem hiding this comment.
This needs a comment //~ ERROR not directly importable for the test to pass
There was a problem hiding this comment.
i.e. use Foo::foo; //~ ERROR not directly importable
…the method causes a compiler panic
rozbb
force-pushed
the
fix-import-trait-method
branch
from
dfad625 to
5a99d79
Compare
|
Thanks! @bors r+ |
|
📌 Commit 5a99d79 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 14, 2016
Fixed issue where importing a trait method directly and then calling the method causes a compiler panic
The code below triggers the panic, and is included in a new regression test.
```rust
trait Foo {
fn foo();
}
use Foo::foo;
fn main() {
foo();
}
```
The bug is caused by `librustc_resolve` allowing the illegal binding to be imported even after displaying the error message above.
The fix amounts to importing a dummy binding (`rustc::hir::def::Def::Err`) instead of the actual trait method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code below triggers the panic, and is included in a new regression test.
The bug is caused by
librustc_resolveallowing the illegal binding to be imported even after displaying the error message above.The fix amounts to importing a dummy binding (
rustc::hir::def::Def::Err) instead of the actual trait method.