std: Fix usage of SOCK_CLOEXEC #34946

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Projects
None yet
6 participants
@alexcrichton
Member

alexcrichton commented Jul 21, 2016

This code path was intended to only get executed on Linux, but unfortunately the
cfg! was malformed so it actually never got executed.

std: Fix usage of SOCK_CLOEXEC
This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Jul 21, 2016

Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Jul 21, 2016

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Jul 21, 2016

Contributor

@bors r+

Contributor

brson commented Jul 21, 2016

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 21, 2016

Contributor

📌 Commit 15cd5a1 has been approved by brson

Contributor

bors commented Jul 21, 2016

📌 Commit 15cd5a1 has been approved by brson

@brson brson added the relnotes label Jul 21, 2016

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 21, 2016

Contributor

⌛️ Testing commit 15cd5a1 with merge 4b0371c...

Contributor

bors commented Jul 21, 2016

⌛️ Testing commit 15cd5a1 with merge 4b0371c...

bors added a commit that referenced this pull request Jul 21, 2016

Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 21, 2016

Contributor

💔 Test failed - auto-linux-64-cargotest

Contributor

bors commented Jul 21, 2016

💔 Test failed - auto-linux-64-cargotest

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jul 21, 2016

Member

@bors: retry

On Wed, Jul 20, 2016 at 6:01 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cargotest
https://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/1194


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JX_cwRUN9dmuS56Vz6pHH6eD2Sdks5qXsTagaJpZM4JRVeA
.

Member

alexcrichton commented Jul 21, 2016

@bors: retry

On Wed, Jul 20, 2016 at 6:01 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cargotest
https://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/1194


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JX_cwRUN9dmuS56Vz6pHH6eD2Sdks5qXsTagaJpZM4JRVeA
.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 21, 2016

Contributor

⌛️ Testing commit 15cd5a1 with merge 4b24e08...

Contributor

bors commented Jul 21, 2016

⌛️ Testing commit 15cd5a1 with merge 4b24e08...

bors added a commit that referenced this pull request Jul 21, 2016

Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 21, 2016

Contributor

💔 Test failed - auto-win-msvc-64-opt-mir

Contributor

bors commented Jul 21, 2016

💔 Test failed - auto-win-msvc-64-opt-mir

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jul 21, 2016

Member

@bors: retry

On Thu, Jul 21, 2016 at 12:39 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-mir
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-mir/builds/1504


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Labf_72DTySjVrco2zfV0cAkkLyks5qX8r_gaJpZM4JRVeA
.

Member

alexcrichton commented Jul 21, 2016

@bors: retry

On Thu, Jul 21, 2016 at 12:39 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-mir
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-mir/builds/1504


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Labf_72DTySjVrco2zfV0cAkkLyks5qX8r_gaJpZM4JRVeA
.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 22, 2016

Contributor

⌛️ Testing commit 15cd5a1 with merge 1054428...

Contributor

bors commented Jul 22, 2016

⌛️ Testing commit 15cd5a1 with merge 1054428...

bors added a commit that referenced this pull request Jul 22, 2016

Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 22, 2016

Contributor

💔 Test failed - auto-win-gnu-32-opt-rustbuild

Contributor

bors commented Jul 22, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jul 22, 2016

Member

@bors: retry

On Fri, Jul 22, 2016 at 4:17 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1912


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95KakrrcAF6y0trCPm3znaSIZZ2nmks5qYU-BgaJpZM4JRVeA
.

Member

alexcrichton commented Jul 22, 2016

@bors: retry

On Fri, Jul 22, 2016 at 4:17 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1912


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95KakrrcAF6y0trCPm3znaSIZZ2nmks5qYU-BgaJpZM4JRVeA
.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 23, 2016

Contributor

⌛️ Testing commit 15cd5a1 with merge 1bdc162...

Contributor

bors commented Jul 23, 2016

⌛️ Testing commit 15cd5a1 with merge 1bdc162...

bors added a commit that referenced this pull request Jul 23, 2016

Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 23, 2016

Contributor

💔 Test failed - auto-linux-64-x-android-t

Contributor

bors commented Jul 23, 2016

💔 Test failed - auto-linux-64-x-android-t

@arielb1

This comment has been minimized.

Show comment
Hide comment
@arielb1

arielb1 Jul 23, 2016

Contributor

@bors retry

Contributor

arielb1 commented Jul 23, 2016

@bors retry

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
Member

alexcrichton commented Jul 25, 2016

@bors: retry

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 25, 2016

Contributor

⌛️ Testing commit 15cd5a1 with merge d33473b...

Contributor

bors commented Jul 25, 2016

⌛️ Testing commit 15cd5a1 with merge d33473b...

bors added a commit that referenced this pull request Jul 25, 2016

Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 25, 2016

Contributor

💔 Test failed - auto-win-gnu-32-opt-rustbuild

Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jul 25, 2016

Member

@bors: retry

On Sun, Jul 24, 2016 at 10:47 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1925


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95LkDh18vC9B9hGz5fkoYmvtVqqT6ks5qZE3dgaJpZM4JRVeA
.

Member

alexcrichton commented Jul 25, 2016

@bors: retry

On Sun, Jul 24, 2016 at 10:47 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1925


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95LkDh18vC9B9hGz5fkoYmvtVqqT6ks5qZE3dgaJpZM4JRVeA
.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
Member

alexcrichton commented Jul 25, 2016

@bors: retry

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 25, 2016

Contributor

⌛️ Testing commit 15cd5a1 with merge 65b403a...

Contributor

bors commented Jul 25, 2016

⌛️ Testing commit 15cd5a1 with merge 65b403a...

bors added a commit that referenced this pull request Jul 25, 2016

Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 25, 2016

Contributor

💔 Test failed - auto-win-gnu-32-opt

Contributor

bors commented Jul 25, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jul 25, 2016

Member

@bors: retry

On Mon, Jul 25, 2016 at 2:59 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5070


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95CF2J5CF1UW_cperKIrl6WJOq7l2ks5qZTGpgaJpZM4JRVeA
.

Member

alexcrichton commented Jul 25, 2016

@bors: retry

On Mon, Jul 25, 2016 at 2:59 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5070


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95CF2J5CF1UW_cperKIrl6WJOq7l2ks5qZTGpgaJpZM4JRVeA
.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 26, 2016

Contributor

⌛️ Testing commit 15cd5a1 with merge d510024...

Contributor

bors commented Jul 26, 2016

⌛️ Testing commit 15cd5a1 with merge d510024...

bors added a commit that referenced this pull request Jul 26, 2016

Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 26, 2016

Contributor

💔 Test failed - auto-win-gnu-32-opt-rustbuild

Contributor

bors commented Jul 26, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jul 26, 2016

Member

@bors: retry

On Tue, Jul 26, 2016 at 3:20 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1953


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95I18rfRgI-2FdCGnvjaFyhA70NGqks5qZd-GgaJpZM4JRVeA
.

Member

alexcrichton commented Jul 26, 2016

@bors: retry

On Tue, Jul 26, 2016 at 3:20 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1953


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95I18rfRgI-2FdCGnvjaFyhA70NGqks5qZd-GgaJpZM4JRVeA
.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 28, 2016

Contributor

⌛️ Testing commit 15cd5a1 with merge f5d7952...

Contributor

bors commented Jul 28, 2016

⌛️ Testing commit 15cd5a1 with merge f5d7952...

bors added a commit that referenced this pull request Jul 28, 2016

Auto merge of #34946 - alexcrichton:fix-cfg, r=brson
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.

@bors bors merged commit 15cd5a1 into rust-lang:master Jul 28, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:fix-cfg branch Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment