Skip to content

Conversation

Jonathan Turner and others added 14 commits July 21, 2016 12:38
Fixed two small spelling mistakes (interator -> iterator) in the documentation for encode_utf8 and encode_utf16
* Modify existing example to not rely on printing to see results
* Add an example demonstrating when slice is shorter than `size`
…r=sanxiyn

Remove unused methods from MultiSpan

Removed a couple of unused methods from MultiSpan.  I thought about batching this with some other changes but wasn't sure when I'd get around to them, so PR for a tiny fix instead.

This can be rollup'd.
… r=eddyb

improve const eval error reporting on "" and b"" casts

r? @eddyb

cc @ubsan
…bnik

Fixed to spelling errors in char.rs

Fixed two small spelling mistakes (interator -> iterator) in the documentation for encode_utf8 and encode_utf16
Doc example improvements for `slice::windows`.

* Modify existing example to not rely on printing to see results
* Add an example demonstrating when slice is shorter than `size`
…=nagisa

Fix incorrect 'memory leak' example for `Vec::set_len`.

Example was written in rust-lang#34911

Issue was brought up in this comment:

rust-lang@a005b2c#commitcomment-18346958
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member Author

@bors-servo r+

@bors
Copy link
Collaborator

bors commented Jul 24, 2016

📌 Commit 52c293c has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors p=10

@bors
Copy link
Collaborator

bors commented Jul 24, 2016

⌛ Testing commit 52c293c with merge 9316ae5...

bors added a commit that referenced this pull request Jul 24, 2016
Rollup of 7 pull requests

- Successful merges: #34965, #34972, #34975, #34976, #34977, #34988, #34989
- Failed merges:
1 similar comment
@bors bors merged commit 52c293c into rust-lang:master Jul 24, 2016
@Manishearth
Copy link
Member Author

MAXIMUM SUCCESS

cc @alexcrichton homu seems to have reproduced?

@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants