Implement RFC 1649 #35719
Merged
Implement RFC 1649 #35719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you also add some tests exercising this functionality? I'd be particularly interested in some tests mixing atomic and It also looks like travis may be failing legitimately? |
|
The doc tests already test the basic functionality. What exactly do you have in mind regarding I've fixed the travis error, it should work now. |
|
Oh right yeah, doc tests are fine for most. But yeah I know we've had interesting interactions with |
|
I added test. |
|
@bors: r+ |
|
📌 Commit ee1fc38 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 19, 2016
Implement RFC 1649 cc #35603 rust-lang/rfcs#1649 r? @alexcrichton
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #35603 rust-lang/rfcs#1649
r? @alexcrichton