Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize type-macros #36014

Merged
merged 1 commit into from Aug 27, 2016
Merged

Stabilize type-macros #36014

merged 1 commit into from Aug 27, 2016

Conversation

@slash3g
Copy link
Contributor

slash3g commented Aug 26, 2016

Closes #27245

r? @nikomatsakis

Closes #27245
@rust-highfive
Copy link
Collaborator

rust-highfive commented Aug 26, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 26, 2016

Looking good! Thanks @slash3g :)

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 26, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2016

📌 Commit ee055a1 has been approved by nikomatsakis

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2016
bors added a commit that referenced this pull request Aug 27, 2016
Rollup of 7 pull requests

- Successful merges: #35124, #35877, #35953, #36002, #36004, #36005, #36014
- Failed merges:
bors added a commit that referenced this pull request Aug 27, 2016
Rollup of 7 pull requests

- Successful merges: #35124, #35877, #35953, #36002, #36004, #36005, #36014
- Failed merges:
bors added a commit that referenced this pull request Aug 27, 2016
Rollup of 7 pull requests

- Successful merges: #35124, #35877, #35953, #36002, #36004, #36005, #36014
- Failed merges:
bors added a commit that referenced this pull request Aug 27, 2016
Rollup of 7 pull requests

- Successful merges: #35124, #35877, #35953, #36002, #36004, #36005, #36014
- Failed merges:
@bors bors merged commit ee055a1 into rust-lang:master Aug 27, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bluss bluss added the relnotes label Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.