Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _, _ with .. in patterns #36203

Merged
merged 2 commits into from
Sep 5, 2016
Merged

Replace _, _ with .. in patterns #36203

merged 2 commits into from
Sep 5, 2016

Conversation

petrochenkov
Copy link
Contributor

This is how #33627 looks in action.

Looks especially nice in leftmost/rightmost positions (first, ..)/(.., last).
I haven't touched libsyntax intentionally because the feature is still unstable.

@petrochenkov
Copy link
Contributor Author

r? @nrc

(This is a formatting/style kind of PR and rustfmt could do this transformation as well).

@nrc
Copy link
Member

nrc commented Sep 2, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 2, 2016

📌 Commit 15dd493 has been approved by nrc

@bors
Copy link
Contributor

bors commented Sep 2, 2016

☔ The latest upstream changes (presumably #35761) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor Author

@bors r=nrc

@bors
Copy link
Contributor

bors commented Sep 2, 2016

📌 Commit e4bff3d has been approved by nrc

@bors
Copy link
Contributor

bors commented Sep 3, 2016

☔ The latest upstream changes (presumably #35957) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor Author

@bors r=nrc

@bors
Copy link
Contributor

bors commented Sep 4, 2016

📌 Commit e05e74a has been approved by nrc

@bors
Copy link
Contributor

bors commented Sep 4, 2016

⌛ Testing commit e05e74a with merge 91f057d...

bors added a commit that referenced this pull request Sep 4, 2016
Replace `_, _` with `..` in patterns

This is how #33627 looks in action.

Looks especially nice in leftmost/rightmost positions `(first, ..)`/`(.., last)`.
I haven't touched libsyntax intentionally because the feature is still unstable.
@bors bors merged commit e05e74a into rust-lang:master Sep 5, 2016
@petrochenkov petrochenkov deleted the uvsdot branch September 21, 2016 19:59
bors added a commit that referenced this pull request Nov 8, 2016
Stabilize `..` in tuple (struct) patterns

I'd like to nominate `..` in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203

Closes #33627
r? @nikomatsakis
bors added a commit that referenced this pull request Nov 8, 2016
Stabilize `..` in tuple (struct) patterns

I'd like to nominate `..` in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203

Closes #33627
r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants