Skip to content

Add changelog for 1.12 #36609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2016
Merged

Add changelog for 1.12 #36609

merged 1 commit into from
Sep 27, 2016

Conversation

brson
Copy link
Contributor

@brson brson commented Sep 21, 2016 •
edited
Loading

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2016
@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

retep998
retep998 suggested changes Sep 21, 2016
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing backtick

WiSaGaN
WiSaGaN reviewed Sep 21, 2016
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/new/now

killercup
killercup reviewed Sep 21, 2016
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing backtick after second macro_rules

japaric
japaric reviewed Sep 21, 2016
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps should mention that these targets produce statically linked binaries.

@brson
Copy link
Contributor Author

brson commented Sep 21, 2016

Updated. Thanks for the feedback.

sfackler
sfackler reviewed Sep 21, 2016
View reviewed changes
RELEASES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if"

@brson brson mentioned this pull request Sep 21, 2016
Merged
@brson
Copy link
Contributor Author

brson commented Sep 21, 2016

I went ahead and ported this to beta as-is.

@brson brson added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Sep 21, 2016
arielb1
arielb1 suggested changes Sep 22, 2016
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only for MIR, and no improvement over pre-MIR.

liigo
liigo reviewed Sep 23, 2016
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--print target-list

wesleywiser
wesleywiser reviewed Sep 27, 2016
View reviewed changes
RELEASES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "inside" instead of "insider"

@brson
Copy link
Contributor Author

brson commented Sep 27, 2016

Updated.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Sep 27, 2016

📌 Commit a6903e4 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Sep 27, 2016

⌛ Testing commit a6903e4 with merge 322b553...

bors added a commit that referenced this pull request Sep 27, 2016
@bors
Auto merge of #36609 - brson:relnotes, r=alexcrichton
322b553 
Add changelog for 1.12

[Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md).
@brson brson added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-accepted Accepted for backporting to the compiler in the beta channel. labels Sep 27, 2016
@brson
Copy link
Contributor Author

brson commented Sep 27, 2016

Now this needs to be backported to the 1.13 beta as well.

@bors
Copy link
Collaborator

bors commented Sep 27, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing 322b553 to master...

@bors bors merged commit a6903e4 into rust-lang:master Sep 27, 2016
@brson brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 5, 2016
@alexcrichton alexcrichton mentioned this pull request Oct 10, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser left review comments

+7 more reviewers

@killercup killercup killercup left review comments

@liigo liigo liigo left review comments

@WiSaGaN WiSaGaN WiSaGaN left review comments

@sfackler sfackler sfackler left review comments

@japaric japaric japaric left review comments

@retep998 retep998 retep998 requested changes

@arielb1 arielb1 arielb1 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@aturon aturon

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.