Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor VecDeque doc examples cleanup. #36664

Merged
merged 1 commit into from Sep 24, 2016
Merged

Minor VecDeque doc examples cleanup. #36664

merged 1 commit into from Sep 24, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@frewsxcv
Copy link
Member Author

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 23, 2016

📌 Commit 3b1b8ae has been approved by GuillaumeGomez

bluss
bluss suggested changes Sep 23, 2016
View reviewed changes
src/libcollections/vec_deque.rs
@@ -726,18 +726,18 @@ impl<T> VecDeque<T> {
/// ```
/// use std::collections::VecDeque;
///
/// let mut vector: VecDeque<u32> = VecDeque::new();
/// let mut vector = VecDeque::<u32>::new();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The element type seems to not be important to the example. Even better to leave it out (and let it fall back to i32)?

src/libcollections/vec_deque.rs
@@ -764,7 +764,7 @@ impl<T> VecDeque<T> {
/// ```
/// use std::collections::VecDeque;
///
/// let mut vector: VecDeque<u32> = VecDeque::new();
/// let mut vector = VecDeque::<u32>::new();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@GuillaumeGomez
Copy link
Member

@bors: r-

@frewsxcv: Please fix @bluss's comments.

@frewsxcv
Copy link
Member Author

Requested changes have been addressed.

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 23, 2016

📌 Commit 3b97344 has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 23, 2016
@GuillaumeGomez
Rollup merge of rust-lang#36664 - frewsxcv:vec-deque, r=GuillaumeGomez
f342ece 
Minor `VecDeque` doc examples cleanup.

None
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 23, 2016
Merged
bors added a commit that referenced this pull request Sep 24, 2016
@bors
Auto merge of #36684 - GuillaumeGomez:rollup, r=GuillaumeGomez
5a71fb3 
Rollup of 7 pull requests

- Successful merges: #36018, #36498, #36500, #36559, #36566, #36578, #36664
- Failed merges:
@bors bors merged commit 3b97344 into rust-lang:master Sep 24, 2016
@frewsxcv frewsxcv deleted the vec-deque branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluss bluss bluss approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frewsxcv @GuillaumeGomez @bors @bluss