New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vec::dedup_by and Vec::dedup_by_key #36743

Merged
merged 4 commits into from Oct 14, 2016

Conversation

Projects
None yet
7 participants
@SimonSapin
Contributor

SimonSapin commented Sep 26, 2016

No description provided.

SimonSapin added some commits Sep 26, 2016

Remove duplicate test.
test_dedup_shared has been exactly the same as test_dedup_unique since
6f16df4, three years ago.
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Sep 26, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SimonSapin

This comment has been minimized.

Contributor

SimonSapin commented Sep 26, 2016

In the spirit of #35856.

(Separate commits show smaller diffs.)

@alexcrichton alexcrichton added the T-libs label Sep 27, 2016

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Sep 27, 2016

Seems like a reasonable addition to me!

cc @rust-lang/libs

@aturon

This comment has been minimized.

Member

aturon commented Sep 27, 2016

I'm 👍 on this addition.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Oct 3, 2016

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

rfcbot commented Oct 3, 2016

FCP proposed with disposition to merge. Review requested from:

No concerns currently listed.
See this document for info about what commands tagged team members can give me.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Oct 3, 2016

Also we'll need to be sure to add a tracking issue for these, but I'm fine with that happening just before merge

@SimonSapin

This comment has been minimized.

Contributor

SimonSapin commented Oct 4, 2016

I’ll open a tracking issue and edit the PR to reference it when (if) this addition is accepted.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Oct 10, 2016

@SimonSapin ok, want to update with an unstable issue reference? I'll r+ after

SimonSapin added some commits Sep 26, 2016

Merge two `impl<T> Vec<T>` blocks.
The show up separately in rustdoc.

This is a separate commit to keep the previous one’s diff shorter.

@SimonSapin SimonSapin force-pushed the SimonSapin:dedup-by branch from 9b61f1e to 401f1c4 Oct 11, 2016

@SimonSapin

This comment has been minimized.

Contributor

SimonSapin commented Oct 11, 2016

Done: #37087.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Oct 11, 2016

@bors: r+

@bors

This comment has been minimized.

Contributor

bors commented Oct 11, 2016

📌 Commit 401f1c4 has been approved by alexcrichton

jonathandturner added a commit to jonathandturner/rust that referenced this pull request Oct 11, 2016

bors added a commit that referenced this pull request Oct 12, 2016

Auto merge of #37093 - jonathandturner:rollup, r=jonathandturner
Rollup of 10 pull requests

- Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067
- Failed merges:

bors added a commit that referenced this pull request Oct 12, 2016

Auto merge of #37093 - jonathandturner:rollup, r=jonathandturner
Rollup of 10 pull requests

- Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067
- Failed merges:
@bors

This comment has been minimized.

Contributor

bors commented Oct 12, 2016

⌛️ Testing commit 401f1c4 with merge 4655164...

bors added a commit that referenced this pull request Oct 12, 2016

Auto merge of #36743 - SimonSapin:dedup-by, r=alexcrichton
Add Vec::dedup_by and Vec::dedup_by_key
@bors

This comment has been minimized.

Contributor

bors commented Oct 12, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@SimonSapin

This comment has been minimized.

Contributor

SimonSapin commented Oct 12, 2016

failures:

---- wrong_checksum_is_an_error stdout ----
    thread 'wrong_checksum_is_an_error' panicked at 'failed to remove dir C:\bot\slave\auto-win-msvc-64-cargotest\build\obj\build\ct\cargo\target\cit\t0\bar\target\debug\deps: The directory is not empty. (os error 145)', tests\cargotest\support\paths.rs:143
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    wrong_checksum_is_an_error

test result: FAILED. 6 passed; 1 failed; 0 ignored; 0 measured



command did not execute successfully: "C:\\bot\\slave\\auto-win-msvc-64-cargotest\\build\\obj\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\cargotest.exe" "C:\\bot\\slave\\auto-win-msvc-64-cargotest\\build\\obj\\build\\x86_64-pc-windows-msvc\\stage0/bin\\cargo.exe" "C:\\bot\\slave\\auto-win-msvc-64-cargotest\\build\\obj\\build\\ct"
expected success, got: exit code: 101


Makefile:51: recipe for target 'check-cargotest' failed

Is this an intermittent failure?

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Oct 13, 2016

@bors: retry

@bors

This comment has been minimized.

Contributor

bors commented Oct 13, 2016

⌛️ Testing commit 401f1c4 with merge a37d74b...

bors added a commit that referenced this pull request Oct 13, 2016

Auto merge of #36743 - SimonSapin:dedup-by, r=alexcrichton
Add Vec::dedup_by and Vec::dedup_by_key
@bors

This comment has been minimized.

Contributor

bors commented Oct 13, 2016

💔 Test failed - auto-linux-cross-opt

@arielb1

This comment has been minimized.

Contributor

arielb1 commented Oct 13, 2016

@bors retry

@bors

This comment has been minimized.

Contributor

bors commented Oct 13, 2016

⌛️ Testing commit 401f1c4 with merge 3ab1839...

bors added a commit that referenced this pull request Oct 13, 2016

Auto merge of #36743 - SimonSapin:dedup-by, r=alexcrichton
Add Vec::dedup_by and Vec::dedup_by_key
@bors

This comment has been minimized.

Contributor

bors commented Oct 13, 2016

💔 Test failed - auto-linux-cross-opt

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Oct 13, 2016

@bors: retry

@bors

This comment has been minimized.

Contributor

bors commented Oct 14, 2016

⌛️ Testing commit 401f1c4 with merge 17af6b9...

bors added a commit that referenced this pull request Oct 14, 2016

Auto merge of #36743 - SimonSapin:dedup-by, r=alexcrichton
Add Vec::dedup_by and Vec::dedup_by_key

@bors bors merged commit 401f1c4 into rust-lang:master Oct 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@rfcbot

This comment has been minimized.

rfcbot commented Oct 17, 2016

All relevant subteam members have reviewed. No concerns remain.

@rfcbot

This comment has been minimized.

rfcbot commented Oct 24, 2016

It has been one week since all blocks to the FCP were resolved.

@SimonSapin SimonSapin deleted the SimonSapin:dedup-by branch Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment