New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM: Add triple for Fuchsia #37261

Merged
merged 2 commits into from Oct 21, 2016

Conversation

Projects
None yet
5 participants
@raphlinus
Contributor

raphlinus commented Oct 18, 2016

Update subproject commit.

Fixes #36920

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 18, 2016

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Oct 18, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Oct 18, 2016

Member

Looks like this update also includes rust-lang/llvm#55 which was being added over at #37125. I'll just close that though in favor of this to prevent conflicts.

@raphlinus could you also update src/rustllvm/llvm-auto-clean-trigger as well? Changing that file will cause a rebuild of LLVM on the buildbots as well.

Member

alexcrichton commented Oct 18, 2016

Looks like this update also includes rust-lang/llvm#55 which was being added over at #37125. I'll just close that though in favor of this to prevent conflicts.

@raphlinus could you also update src/rustllvm/llvm-auto-clean-trigger as well? Changing that file will cause a rebuild of LLVM on the buildbots as well.

@alexcrichton alexcrichton referenced this pull request Oct 18, 2016

Closed

Update LLVM #37125

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Oct 18, 2016

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 18, 2016

Contributor

📌 Commit 83f1050 has been approved by alexcrichton

Contributor

bors commented Oct 18, 2016

📌 Commit 83f1050 has been approved by alexcrichton

@eddyb eddyb referenced this pull request Oct 19, 2016

Merged

Rollup of 23 pull requests #37269

bors added a commit that referenced this pull request Oct 19, 2016

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 19, 2016

Contributor

☔️ The latest upstream changes (presumably #37269) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented Oct 19, 2016

☔️ The latest upstream changes (presumably #37269) made this pull request unmergeable. Please resolve the merge conflicts.

@bluss

This comment has been minimized.

Show comment
Hide comment
@bluss

bluss Oct 19, 2016

Contributor

I edited the PR description to indicate an issue it fixes (so that it closes automatically).

Contributor

bluss commented Oct 19, 2016

I edited the PR description to indicate an issue it fixes (so that it closes automatically).

raphlinus added some commits Oct 18, 2016

LLVM: Add triple for Fuchsia
Update subproject commit.
Update llvm-auto-clean-trigger
Update the datestamp so that buildbots do a clean rebuild of llvm.
@bluss

This comment has been minimized.

Show comment
Hide comment
@bluss

bluss Oct 20, 2016

Contributor

@bors r+

Contributor

bluss commented Oct 20, 2016

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 20, 2016

Contributor

📌 Commit b8697d9 has been approved by bluss

Contributor

bors commented Oct 20, 2016

📌 Commit b8697d9 has been approved by bluss

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 20, 2016

Contributor

⌛️ Testing commit b8697d9 with merge f094206...

Contributor

bors commented Oct 20, 2016

⌛️ Testing commit b8697d9 with merge f094206...

bors added a commit that referenced this pull request Oct 20, 2016

Auto merge of #37261 - raphlinus:update_llvm, r=bluss
LLVM: Add triple for Fuchsia

Update subproject commit.

Fixes #36920

@bors bors merged commit b8697d9 into rust-lang:master Oct 21, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@raphlinus raphlinus deleted the raphlinus:update_llvm branch Oct 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment