New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fuchsia support #37313

Merged
merged 4 commits into from Oct 24, 2016

Conversation

Projects
None yet
5 participants
@raphlinus
Contributor

raphlinus commented Oct 20, 2016

Adds support for the x86_64-unknown-fuchsia target, which covers the
Fuchsia operating system.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 20, 2016

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Oct 20, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@raphlinus

This comment has been minimized.

Show comment
Hide comment
@raphlinus

raphlinus Oct 20, 2016

Contributor

@alexcrichton Note that this PR is dependent on rust-lang/libc#432 to actually work. It also requires a clang wrapper which has not yet been added to the fuchsia repository.

Comments welcome. One missing piece is aarch64 support (it's x86_64 only for now), one of the two officially supported architectures for Fuchsia. But I figure it might be useful to get feedback at this stage.

Contributor

raphlinus commented Oct 20, 2016

@alexcrichton Note that this PR is dependent on rust-lang/libc#432 to actually work. It also requires a clang wrapper which has not yet been added to the fuchsia repository.

Comments welcome. One missing piece is aarch64 support (it's x86_64 only for now), one of the two officially supported architectures for Fuchsia. But I figure it might be useful to get feedback at this stage.

@alexcrichton

Looks great to me! Let's get the libc PR merged as well yeah so it can be included here.

Show outdated Hide outdated src/libstd/sys/unix/ext/fs.rs
pub use libc::{off_t, ino_t, nlink_t, blksize_t, blkcnt_t, stat, time_t};
}
#[cfg(target_arch = "aarch64")]

This comment has been minimized.

@alexcrichton

alexcrichton Oct 20, 2016

Member

You can probably simplify a bunch of this right as only x86_64 is needed for now?

@alexcrichton

alexcrichton Oct 20, 2016

Member

You can probably simplify a bunch of this right as only x86_64 is needed for now?

This comment has been minimized.

@raphlinus

raphlinus Oct 20, 2016

Contributor

I chose these based on what's plausibly supported by the Magenta kernel. aarch64 is an officially supported Fuchsia target, and I'd like to get that in soon (possibly as an update to his PR). Magenta kernel also supports 32 bit targets, and I don't want to necessarily preclude Rust on those targets either.

@raphlinus

raphlinus Oct 20, 2016

Contributor

I chose these based on what's plausibly supported by the Magenta kernel. aarch64 is an officially supported Fuchsia target, and I'd like to get that in soon (possibly as an update to his PR). Magenta kernel also supports 32 bit targets, and I don't want to necessarily preclude Rust on those targets either.

This comment has been minimized.

@alexcrichton

alexcrichton Oct 21, 2016

Member

Ah never mind me then!

@alexcrichton

alexcrichton Oct 21, 2016

Member

Ah never mind me then!

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Oct 21, 2016

Member

Oh looks like make tidy is also complaining about a few locations?

Member

alexcrichton commented Oct 21, 2016

Oh looks like make tidy is also complaining about a few locations?

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Oct 21, 2016

Member

Want to update the libc submodule now as well?

Member

alexcrichton commented Oct 21, 2016

Want to update the libc submodule now as well?

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Oct 21, 2016

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 22, 2016

Contributor

☔️ The latest upstream changes (presumably #37337) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented Oct 22, 2016

☔️ The latest upstream changes (presumably #37337) made this pull request unmergeable. Please resolve the merge conflicts.

raphlinus added some commits Oct 18, 2016

Add Fuchsia support
Adds support for the x86_64-unknown-fuchsia target, which covers the
Fuchsia operating system.
Fix missing DirEntryExt::ino
The DirEntryExt::ino() implementation was omitted from the first
iteration of this patch, because a dependency needed to be
configured. The fix is straightforward enough.
Fix tidy warning
Prefer FIXME to TODO
Update libc submodule with corresponding fuchsia changes
Also trim os::fuchsia::raw architectures.
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Oct 24, 2016

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 24, 2016

Contributor

📌 Commit cea6140 has been approved by alexcrichton

Contributor

bors commented Oct 24, 2016

📌 Commit cea6140 has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 24, 2016

Contributor

⌛️ Testing commit cea6140 with merge 3caf63c...

Contributor

bors commented Oct 24, 2016

⌛️ Testing commit cea6140 with merge 3caf63c...

bors added a commit that referenced this pull request Oct 24, 2016

Auto merge of #37313 - raphlinus:fuchsia, r=alexcrichton
Add Fuchsia support

Adds support for the x86_64-unknown-fuchsia target, which covers the
Fuchsia operating system.

@bors bors merged commit cea6140 into rust-lang:master Oct 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@raphlinus raphlinus deleted the raphlinus:fuchsia branch Oct 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment