Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Fuchsia support #37313
Conversation
rust-highfive
assigned
sfackler
Oct 20, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton Note that this PR is dependent on rust-lang/libc#432 to actually work. It also requires a clang wrapper which has not yet been added to the fuchsia repository. Comments welcome. One missing piece is aarch64 support (it's x86_64 only for now), one of the two officially supported architectures for Fuchsia. But I figure it might be useful to get feedback at this stage. |
alexcrichton
reviewed
Oct 20, 2016
|
Looks great to me! Let's get the libc PR merged as well yeah so it can be included here. |
| @@ -312,6 +312,7 @@ pub trait DirEntryExt { | |||
| } | |||
|
|
|||
| #[stable(feature = "dir_entry_ext", since = "1.1.0")] | |||
| #[cfg(not(target_os = "fuchsia"))] | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| pub use libc::{off_t, ino_t, nlink_t, blksize_t, blkcnt_t, stat, time_t}; | ||
| } | ||
|
|
||
| #[cfg(target_arch = "aarch64")] |
This comment has been minimized.
This comment has been minimized.
alexcrichton
Oct 20, 2016
Member
You can probably simplify a bunch of this right as only x86_64 is needed for now?
This comment has been minimized.
This comment has been minimized.
raphlinus
Oct 20, 2016
Author
Contributor
I chose these based on what's plausibly supported by the Magenta kernel. aarch64 is an officially supported Fuchsia target, and I'd like to get that in soon (possibly as an update to his PR). Magenta kernel also supports 32 bit targets, and I don't want to necessarily preclude Rust on those targets either.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Oh looks like |
This comment has been minimized.
This comment has been minimized.
|
Want to update the libc submodule now as well? |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
raphlinus
added some commits
Oct 18, 2016
raphlinus
force-pushed the
raphlinus:fuchsia
branch
from
51673d3
to
cea6140
Oct 22, 2016
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Oct 24, 2016
raphlinus commentedOct 20, 2016
Adds support for the x86_64-unknown-fuchsia target, which covers the
Fuchsia operating system.