Skip to content

save-analysis: handle << and >> operators inside [] in types #37776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2016
Merged

save-analysis: handle << and >> operators inside [] in types #37776

merged 1 commit into from
Nov 18, 2016

Conversation

nrc
Copy link
Member

@nrc nrc commented Nov 15, 2016

Fixes #37700

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Nov 16, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 16, 2016

📌 Commit e003d05 has been approved by brson

nikomatsakis
nikomatsakis reviewed Nov 16, 2016
View reviewed changes
src/librustc_save_analysis/span_utils.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is a bit obscure. It seems like some comments might help to clarify what's going on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add

nikomatsakis
nikomatsakis reviewed Nov 16, 2016
View reviewed changes
src/test/run-make/save-analysis/foo.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really get what the logic is above, but I am wondering if it is going to work for something like Option<[u8; foo(X > Y)]> (where foo() is a const fn)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it should do, that is kind of the point - this basically ignores any angle bracket-like tokens which occur inside [ ... ] because they could be part of expressions.

@nrc nrc force-pushed the save-double-angle branch from e003d05 to 8a949df Compare November 18, 2016 00:06
@nrc
Copy link
Member Author

nrc commented Nov 18, 2016

Now with a comment.

@bors: r=@brson

@bors
Copy link
Collaborator

bors commented Nov 18, 2016

📌 Commit 8a949df has been approved by @brson

@bors
Copy link
Collaborator

bors commented Nov 18, 2016

⌛ Testing commit 8a949df with merge b7dfc2b...

bors added a commit that referenced this pull request Nov 18, 2016
@bors
Auto merge of #37776 - nrc:save-double-angle, r=@brson
b7dfc2b 
save-analysis: handle << and >> operators inside [] in types

Fixes #37700
@bors
Copy link
Collaborator

bors commented Nov 18, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: @brson
Pushing b7dfc2b to master...

@bors bors merged commit 8a949df into rust-lang:master Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nrc @rust-highfive @brson @bors @nikomatsakis