Restore compatibility with LLVM 3.7 and 3.8 #37912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit c45f3de has been approved by |
|
@bors p=2 (just in case a PR with a lower number like mine is r plussed in the interim) |
bors
added a commit
that referenced
this pull request
Nov 21, 2016
Restore compatibility with LLVM 3.7 and 3.8 This should fix Travis build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37831 broke compatibility with LLVM 3.7 and 3.8. While LLVM Attribute API has been there for a long time, LLVM Attribute API C binding, including LLVMAttributeRef type, is new in LLVM 3.9. This patch avoids uses of LLVMAttributeRef.
This should fix Travis build.