New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current_exe() on DragonFly (again) #38197

Merged
merged 1 commit into from Dec 9, 2016

Conversation

Projects
None yet
4 participants
@mneumann
Copy link
Contributor

mneumann commented Dec 6, 2016

This is a follow up on this pull request.

Since DragonFly 4.6.1 (this commit), the kern.proc.pathname
sysctl works correctly, i.e. it does not return paths including a :
(see here). Use it and don't try to fix old versions of DragonFly!
There are not many DragonFly installations out there that we can't
control and no one is compiling Rust from source. If someone wants to
run Rust on a pre-4.6.1 DragonFly system, the ports system should
provide a patch.

Fix current_exe() on DragonFly (again)
This is a follow up on [this pull request][1].

Since DragonFly 4.6.1 ([this commit][2]), the "kern.proc.pathname"
sysctl works correctly, i.e. it does not return paths including a ":"
(see [here][3]). Use it and don't try to fix old versions of DragonFly!
There are not many DragonFly installations out there that we can't
control and no one is compiling Rust from source. If someone wants to
run Rust on a pre-4.6.1 DragonFly system, the ports system should
provide a patch.

[1]: #35494
[2]: https://gitweb.dragonflybsd.org/dragonfly.git/commit/726f7ca07e193db73635e9c4e24e40c96087d6d9
[3]: https://gist.github.com/mneumann/a2f6b6a0a03935b561d6185872a4b222
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 6, 2016

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Dec 6, 2016

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 6, 2016

📌 Commit dfd3b90 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 9, 2016

⌛️ Testing commit dfd3b90 with merge 51d2934...

bors added a commit that referenced this pull request Dec 9, 2016

Auto merge of #38197 - mneumann:dragonfly-fixes-2016-12-06, r=alexcri…
…chton

Fix current_exe() on DragonFly (again)

This is a follow up on [this pull request][1].

Since DragonFly 4.6.1 ([this commit][2]), the ```kern.proc.pathname```
sysctl works correctly, i.e. it does not return paths including a ```:```
(see [here][3]). Use it and don't try to fix old versions of DragonFly!
There are not many DragonFly installations out there that we can't
control and no one is compiling Rust from source. If someone wants to
run Rust on a pre-4.6.1 DragonFly system, the ports system should
provide a patch.

[1]: #35494
[2]: https://gitweb.dragonflybsd.org/dragonfly.git/commit/726f7ca07e193db73635e9c4e24e40c96087d6d9
[3]: https://gist.github.com/mneumann/a2f6b6a0a03935b561d6185872a4b222

@bors bors merged commit dfd3b90 into rust-lang:master Dec 9, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@mneumann mneumann deleted the mneumann:dragonfly-fixes-2016-12-06 branch Dec 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment