Reword 'stupid' and 'crazy' in docs. #38782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
clarfonthey
changed the title
steveklabnik
suggested changes
Jan 2, 2017
| @@ -74,8 +74,7 @@ The remaining architectures look like: | |||
| ## QEMU | |||
|
|
|||
| Lots of the architectures tested here use QEMU in the tests, so it's worth going | |||
| over all the crazy capabilities QEMU has and the various flavors in which we use | |||
| it! | |||
| over all the capabilities QEMU has and the various flavors in which we use it! | |||
There was a problem hiding this comment.
this change can't work; this is a vendored copy of the https://github.com/rust-lang/libc crate, and would need to be fixed there, that's why CI is failing.
| # If we don't have a cross-compiler, however, then we need to do some | ||
| # convoluted acrobatics to get this to work. Generate all.{c,rs} on the host | ||
| # which will be compiled inside QEMU. Do this here because compiling | ||
| # syntex_syntax in QEMU would time out basically everywhere. |
|
Ah, I tried to avoid searching through the submodules and I guess that I missed some. Removed the vendor changes and rebased. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 8ffc3e7 has been approved by |
|
⌛ Testing commit 8ffc3e7 with merge 2bb0dcc... |
|
💔 Test failed - status-travis |
|
Failure is irrelevant. |
|
@bors: retry |
|
⌛ Testing commit 8ffc3e7 with merge 1659d65... |
bors
added a commit
that referenced
this pull request
Jan 3, 2017
Reword 'stupid' and 'crazy' in docs. These terms are not very descriptive and are better reworded as something else.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These terms are not very descriptive and are better reworded as something else.