Make members of {std,core}::{i128,u128} unstable #38861
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
est31
force-pushed
the
master
branch
2 times, most recently
from
b3e38cb
to
c198fcb
Compare
Adding it in a stable form was an accident. It thankfully only leaked to nightly. Fixes rust-lang#38860
|
@bors: r+ Thanks! |
|
📌 Commit 1779ffa has been approved by |
| // except according to those terms. | ||
|
|
||
| fn testl() { | ||
| ::std::u128::MAX; //~ ERROR use of unstable library feature 'i128' |
There was a problem hiding this comment.
The error should be u128, no?
There was a problem hiding this comment.
No, the feature is named i128, there is one for both i128 and u128.
| @@ -14,4 +14,4 @@ | |||
|
|
|||
| #![unstable(feature = "i128", issue="35118")] | |||
|
|
|||
| int_module! { i128 } | |||
| int_module! { i128, #[unstable(feature = "i128", issue="35118")] } | |||
There was a problem hiding this comment.
The feature name was defined to be i128_type here
https://github.com/rust-lang/rust/blob/master/src/libsyntax/feature_gate.rs#L323
Should this match that definition?
There was a problem hiding this comment.
They are two different features. One (i128_type) gates the actual type in the language, the other (i128) gates the library members. Here we use the library gating one.
There was a problem hiding this comment.
Thanks for the explanation!
|
⌛ Testing commit 1779ffa with merge bb7e7ef... |
Make members of {std,core}::{i128,u128} unstable
Fixes #38860
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #38860