std/net/udp: Improve set_nonblocking test #38986

Merged
merged 1 commit into from Jan 14, 2017

Projects

None yet

4 participants

@APTy
Contributor
APTy commented Jan 11, 2017

While writing a separate change, I noticed the current test for UdpSocket::set_nonblocking() is fairly ineffective.

This fixes the test so that it validates that a correct error is returned on calls to recv() when no data is available.

@rust-highfive
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aturon
Contributor
aturon commented Jan 11, 2017

Looks great, thanks!

@bors: r+ rollup

@bors
Contributor
bors commented Jan 11, 2017

📌 Commit 3038013 has been approved by aturon

@GuillaumeGomez GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 12, 2017
@GuillaumeGomez GuillaumeGomez Rollup merge of #38986 - APTy:fix-nonblocking-test, r=aturon
std/net/udp: Improve set_nonblocking test

While writing a separate change, I noticed the current test for `UdpSocket::set_nonblocking()` is fairly ineffective.

This fixes the test so that it validates that a correct error is returned on calls to `recv()` when no data is available.
211f64b
@bors bors added a commit that referenced this pull request Jan 12, 2017
@bors bors Auto merge of #39011 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 9 pull requests

- Successful merges: #38362, #38629, #38636, #38877, #38946, #38965, #38986, #38994, #38995
- Failed merges:
117753d
@GuillaumeGomez GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 13, 2017
@GuillaumeGomez GuillaumeGomez Rollup merge of #38986 - APTy:fix-nonblocking-test, r=aturon
std/net/udp: Improve set_nonblocking test

While writing a separate change, I noticed the current test for `UdpSocket::set_nonblocking()` is fairly ineffective.

This fixes the test so that it validates that a correct error is returned on calls to `recv()` when no data is available.
629caf5
@bors bors added a commit that referenced this pull request Jan 13, 2017
@bors bors Auto merge of #39030 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 10 pull requests

- Successful merges: #38362, #38636, #38877, #38946, #38965, #38986, #38994, #38995, #39024, #39027
- Failed merges:
bbf0735
@bors bors added a commit that referenced this pull request Jan 13, 2017
@bors bors Auto merge of #39030 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 10 pull requests

- Successful merges: #38362, #38636, #38877, #38946, #38965, #38986, #38994, #38995, #39024, #39027
- Failed merges:
7789881
@bors bors merged commit 3038013 into rust-lang:master Jan 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment