Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the second edition #39043

Closed
wants to merge 1 commit into from
Closed

Conversation

jmdyck
Copy link

@jmdyck jmdyck commented Jan 13, 2017

... and a warning that this edition isn't really being maintained.

See #39038 (comment)

... and a warning that this edition isn't really being maintained.

See rust-lang#39038 (comment)
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

/cc @rust-lang/docs @rust-lang/core

We haven't decided when to do something like this. Is now the time?

@GuillaumeGomez
Copy link
Member

We started the discussion but nothing much. Maybe we should wait after the next meeting to give it a go or not?

@frewsxcv
Copy link
Member

As such, we're not really editing this edition.

This doesn't seem entirely accurate. Although it doesn't get as much love as it used to, Book 1.0 still receives edits now and then:

https://github.com/rust-lang/rust/commits/master/src/doc/book

In my opinion, until we start suggesting Book 2.0, I think it makes sense to keep Book 1.0 on life support. So I don't think we should discourage people from editing Book 1.0.

@frewsxcv frewsxcv added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Jan 14, 2017
@steveklabnik
Copy link
Member

@jmdyck thank you for this PR, but I think I'm going to close it. Not because it's bad, exactly, but because with the impending merge of rust-lang/rfcs#1828, we will be covering this as part of that work, and it would go in a totally different place.

@jmdyck
Copy link
Author

jmdyck commented Jan 24, 2017

Okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants