Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Copy link
Contributor

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with my comment addressed

///
/// If the array has 32 or fewer elements (see above), you can also use the
/// array reference's `IntoIterator` implementation:
/// array reference's [`IntoIterator`] implementation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be:

[`IntoIterator`][intoiterator]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try to keep the syntax I've put in here. So not sure if I should change it or not...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to change the item using [intoiterator] then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't intend to, however I can "reverse" the other urls if you prefer.

@frewsxcv
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 25, 2017

📌 Commit c8d1f32 has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2017
bors added a commit that referenced this pull request Jan 25, 2017
Rollup of 6 pull requests

- Successful merges: #38930, #39212, #39251, #39267, #39276, #39278
- Failed merges:
@bors bors merged commit c8d1f32 into rust-lang:master Jan 25, 2017
@GuillaumeGomez GuillaumeGomez deleted the array_urls branch January 25, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants