Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aarch64-unknown-freebsd #39491

Merged
merged 2 commits into from Feb 5, 2017

Conversation

@dumbbell
Copy link
Contributor

dumbbell commented Feb 3, 2017

No description provided.

dumbbell added 2 commits Jan 25, 2017
@dumbbell dumbbell changed the title Support aarch64 unknown freebsd Support aarch64-unknown-freebsd Feb 3, 2017
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 3, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@dumbbell

This comment has been minimized.

Copy link
Contributor Author

dumbbell commented Feb 3, 2017

To test this patch, I cross-compiled Rust and Cargo on FreeBSD/x86_64. I used the result on FreeBSD/aarch64 to check that Rust could self-host.

This pull request goes with rust-lang/libc#512.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 3, 2017

@bors: r+

Thanks!

cc @rust-lang/tools

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 3, 2017

📌 Commit f6c6b31 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…eebsd, r=alexcrichton

Support aarch64-unknown-freebsd
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…eebsd, r=alexcrichton

Support aarch64-unknown-freebsd
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…eebsd, r=alexcrichton

Support aarch64-unknown-freebsd
bors added a commit that referenced this pull request Feb 5, 2017
Rollup of 12 pull requests

- Successful merges: #39439, #39472, #39481, #39491, #39501, #39509, #39514, #39519, #39526, #39528, #39530, #39538
- Failed merges:
@bors bors merged commit f6c6b31 into rust-lang:master Feb 5, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dumbbell dumbbell deleted the dumbbell:support-aarch64-unknown-freebsd branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.