Rename manifest_version to manifest-version #39630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
brson
reviewed
Feb 7, 2017
src/tools/build-manifest/src/main.rs
Outdated
| let manifest = self.build_manifest(); | ||
| let Manifest { manifest_version, date, pkg } = self.build_manifest(); | ||
| let mut manifest = BTreeMap::new(); | ||
| manifest.insert("manifest-version".to_string(), |
There was a problem hiding this comment.
Please add a comment explaining that rebuilding of the manifest BTreeMap is to correct the 'manifest-version' name.
|
r=me w/ nit |
The current manifests encode this with a dash in the name, so we should preserve that!
alexcrichton
force-pushed
the
update-manifest
branch
from
c976680 to
e53eaa3
Compare
|
@bors: r=brson |
|
📌 Commit e53eaa3 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 8, 2017
Rename manifest_version to manifest-version The current manifests encode this with a dash in the name, so we should preserve that!
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 8, 2017
Rename manifest_version to manifest-version The current manifests encode this with a dash in the name, so we should preserve that!
alexcrichton
added
the
beta-nominated
|
Nominating for a beta backport |
alexcrichton
added
the
beta-accepted
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current manifests encode this with a dash in the name, so we should preserve
that!