Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Better explanation of return values for min, max functions for the Iterator trait #39955

Merged
merged 1 commit into from Feb 20, 2017

Conversation

mp4096
Copy link
Contributor

@mp4096 mp4096 commented Feb 19, 2017

Added an explanation that None is returned if an iterator is empty.

Also added examples for max and min. I chose not to add examples for other functions like max_by_key etc. so that the examples stay concised and focused on the main functionality.

Explain that a None is returned if the iterator is empty.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Excellent, thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 19, 2017

📌 Commit eee6752 has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 19, 2017
Docs: Better explanation of return values for min, max functions for the Iterator trait

Added an explanation that `None` is returned if an iterator is empty.

Also added examples for `max` and `min`. I chose not to add examples for other functions like `max_by_key` etc. so that the examples stay concised and focused on the main functionality.
@bors
Copy link
Contributor

bors commented Feb 20, 2017

⌛ Testing commit eee6752 with merge f57a027...

bors added a commit that referenced this pull request Feb 20, 2017
Docs: Better explanation of return values for min, max functions for the Iterator trait

Added an explanation that `None` is returned if an iterator is empty.

Also added examples for `max` and `min`. I chose not to add examples for other functions like `max_by_key` etc. so that the examples stay concised and focused on the main functionality.
@bors
Copy link
Contributor

bors commented Feb 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing f57a027 to master...

@bors bors merged commit eee6752 into rust-lang:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants